Skip to content

param: fix bug with param names that are substrings of other param names #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jschall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

param: fix bug with param names that are substrings of other param names #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/param/param.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,14 @@ enum param_type_t param_get_type_by_index(uint16_t param_idx) {
}

int16_t param_get_index_by_name(uint8_t name_len, char* name) {
if (name_len > 92) {
return -1;
}

for (uint16_t i=0; i<num_params_registered; i++) {
const struct param_descriptor_header_s* descriptor = param_descriptor_table[i];

if(!strncmp(name, descriptor->name, MIN(name_len,92))) {
if(!strncmp(name, descriptor->name, name_len) && name_len == strnlen(descriptor->name, 92)) {
return i;
}
}
Expand Down