A few updates from with GTOC #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| shape = options['shape'] | ||
| if isinstance(shape, int): | ||
| shape = (shape,) | ||
| val_shape = (num_nodes,) + shape |
Member
There was a problem hiding this comment.
Might be cleaner to just compute val_shape once and then use it for all three different kinds of targerts, since it only depends on options.
dymos/phase/phase.py
Outdated
| configure_controls_introspection, configure_parameters_introspection, \ | ||
| configure_timeseries_output_introspection, classify_var | ||
| from ..utils.misc import _unspecified, create_subprob | ||
| from ..utils.misc import _unspecified, create_subprob, is_scalar_or_singleton |
Member
There was a problem hiding this comment.
I was hoping you were getting rid of the relative import while you were here...
Contributor
Author
There was a problem hiding this comment.
Consider this a christmas present from me :)
| """ | ||
| raise NotImplementedError(f'Transcription {self.__class__.__name__} does not implement method ' | ||
| '_phase_set_val.') | ||
| # All phases at least set state vals at the input nodes |
Member
There was a problem hiding this comment.
"all phases" means "all transcriptions" ?
| # Case 2: We've been given a single value of a shaped state. | ||
| state_vals = np.broadcast_to(vals_array, (num_state_input_nodes,) + state_shape) | ||
| else: | ||
| if time_vals is None: |
Member
There was a problem hiding this comment.
This "else" statement only contains an if/elif/else block, so I think you can bring them all up one level into the main if.
Kenneth-T-Moore
approved these changes
Dec 1, 2025
Member
Kenneth-T-Moore
left a comment
Kenneth-T-Moore
left a comment
There was a problem hiding this comment.
Looks good, but see comments.
…rkhoff will at least report errors. In BirkhoffDefectComp, the state_defect which is linear when fix_intial/fix_final is True, is NOT linear when fix_initial/fix_final are False AND they are connected to a nonlinear output. TODO: Think of a better way to characterize that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(num_state_input_nodes,) + shapeset of state values.(num_control_input_nodes,) + shapeRelated Issues
None
Backwards incompatibilities
None
New Dependencies
None