Combined engine_builders and external subsystem loading api
#949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed incorrect handling for engine models
Kenneth-T-Moore
approved these changes
Jan 6, 2026
Member
Kenneth-T-Moore
left a comment
Kenneth-T-Moore
left a comment
There was a problem hiding this comment.
This looks good. The current doc failure might be a corner case with turboprop that isn't currently covered in our regular tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
You no longer have to separately load engines using
engine_modelsargument in multiple level 2 api locations. All engines are now added using theload_external_subsystems()method, and Aviary will sort out which provided subsystems are EngineModels and correctly add them to propulsion.You can now add external subsystems in the level1 api.
Related Issues
Backwards incompatibilities
Any scripts using
engine_builderswill have to switch to the new api (no change in functionality).engine_buildersis deprecated across AviaryNew Dependencies
None