Mass report update - FLOPS #942
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| outputs.set_val(Aircraft.LandingGear.MAIN_GEAR_MASS, 0.85 * 5778.0, 'lbm') | ||
| outputs.set_val(Aircraft.LandingGear.NOSE_GEAR_MASS, 0.15 * 5778.0, 'lbm') | ||
| outputs.set_val(Aircraft.LandingGear.TOTAL_MASS, 4911.3 + 866.7, 'lbm') |
Member
There was a problem hiding this comment.
Let's just make this the 5778.0 from the above 2 lines....
| Aircraft.Design.TOUCHDOWN_MASS, | ||
| ], | ||
| ) | ||
| self.declare_partials( |
Member
There was a problem hiding this comment.
There is a problem here if we override one of the gear masses, but let Aviary compute the other (I know, an odd corner case, but it is possible). In that case, the total will be wrong. To overcome this, best to implement the total as a separate component.
Fixed missing propulsion mass entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates mass reporting for FLOPS-based mass to conform to SAWE RP-8 standard.
Some mass variables have been renamed to comply with the standard, and the FLOPS-based mass summation component was reworked to group masses appropriately.
Generative AI was used to write a new test that checks matching between hierarchy variable names and string representation (test_var_structure.py). The Cursor IDE was used, which does not expose which specific models it uses. Manual review and minor tweaks were done by hand.
Related Issues
Backwards incompatibilities
Renamed variables:
Aircraft.CrewPayload.NON_FLIGHT_CREW_MASS->Aircraft.CrewPayload.CABIN_CREW_MASSAircraft.CrewPayload.NON_FLIGHT_CREW_MASS_SCALER->Aircraft.CrewPayload.CABIN_CREW_MASS_SCALERAircraft.CrewPayload.PASSENGER_MASS->Aircraft.CrewPayload.PASSENGER_MASS_TOTALAircraft.CrewPayload.PASSENGER_MASS_WITH_BAGS->Aircraft.CrewPayload.MASS_PER_PASSENGER_WITH_BAGSAircraft.Controls.TOTAL_MASS->Aircraft.Controls.MASSAircraft.Design.SYSTEMS_EQUIP_MASS->Aircraft.Design.SYSTEMS_AND_EQUIPMENT_MASSAircraft.Design.SYSTEMS_EQUIP_MASS_BASE->Aircraft.Design.SYSTEMS_AND_EQUIPMENT_MASS_BASEAircraft.Wing.ASPECT_RATIO_REF->Aircraft.Wing.ASPECT_RATIO_REFERENCEAircraft.Wing.THICKNESS_TO_CHORD_REF->Aircraft.Wing.THICKNESS_TO_CHORD_REFERENCENew Dependencies
None