WIP fixes for turboprop aircraft #926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/om-Aviary into turboprop_freighter_fixes
… turboprop_freighter_fixes
jkirk5
commented
Dec 1, 2025
| if var in lists_to_link[idx]: | ||
| phases_to_link.append(phase_name) | ||
|
|
||
| if len(phases_to_link) > 1: # TODO: hack |
Contributor
Author
There was a problem hiding this comment.
Experimental fix for external subsystem linked variables across analytic phases
jkirk5
commented
Dec 1, 2025
jkirk5
commented
Dec 1, 2025
| 'upper': 0.5, | ||
| # 'val': 0.5, | ||
| }, | ||
| # Aircraft.Engine.Propeller.ACTIVITY_FACTOR: { |
Contributor
Author
There was a problem hiding this comment.
This is actually a new problem - these are the design variables that could get added, but you don't always want them added to the problem, only when you want to resize the propeller (and even then, maybe you don't want diameter to change, for example). We don't have a good way to easily let the user set this right now
Member
There was a problem hiding this comment.
In MBSAE, the way to handle this has been to manually comment out design vars, but you could add a flag to the builder initialization arguments, and use this flag to determine the var configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A variety of bugfixes and changes to improve the turboprop freighter model. NOTE this is a partial fix and does not mean the turboprop freighter is finished at this point.
Changes include cleaning up and standardizing the electric breguet range ODEs and phases, getting parts of 2DOF working with external subsystems (a new feature technically!), and lots of fixes geared towards the freighter model itself
Related Issues
Backwards incompatibilities
None
New Dependencies
None