FLOPS based premission for BWB #922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alculated_wing_area'.
…s_weight in Aviary.
…ASS, set 'WTIN.NPT' for FLOPS for Aircraft.CrewPayload.Design.NUM_TOURIST_CLASS. In this way, fortran_to_aviary can read in NPF and NPT.
…rcraft.Wing.SPAN is computed.
…nto BWB_FLOPS_premission
jkirk5
reviewed
Jan 9, 2026
| # Temporarily add extra stuff here, probably patched soon | ||
| if mission_method is HEIGHT_ENERGY: | ||
| # add a check for traj using hasattr for pre-mission tests. | ||
| if mission_method is HEIGHT_ENERGY and hasattr(self, 'traj'): |
Contributor
There was a problem hiding this comment.
What scenario did the AviaryGroup not have 'traj'? That seems like a serious bug that needs to get fixed!!
| inputs.set_val(Aircraft.Engine.DATA_FILE, filename) | ||
| inputs.set_val(Aircraft.Engine.MASS, 6293.8, 'lbm') | ||
| inputs.set_val(Aircraft.Engine.REFERENCE_MASS, 6293.8, 'lbm') | ||
| inputs.set_val(Aircraft.Engine.REFERENCE_MASS, np.array([6293.8]), 'lbm') |
Contributor
There was a problem hiding this comment.
Do your tests & benchmarks work without these changes? If they do not, then we need to fix those - I can help
| @@ -0,0 +1,654 @@ | |||
| # created 10/08/25 at 13:25 by xjiang | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # created 10/08/25 at 13:25 by xjiang | |
| # created 10/08/25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a unit test for FLOPS based subsystems with BWB configuration (see
BWBPreMissionGroupTestclass intest_flops_based_premission.py). This PR assumes that geometry and mass subsystems are already implemented using BWB using FLOPS code. Since there is no specific code in FLOPS for BWB, this unit test covers all four basic subsystems: propulsion, geometry, aerodynamics and mass.As in PR #889 for mass subsystem, we prepare two cases for the testing: Case 1 with simple fuselage layout and simple wing layout (see
bwb_simple_FLOPS_data.py) and case 2 with detailed fuselage layout and detailed wing layout (seebwb_detailed_FLOPS_data.py) in aircraft model directory.Almost all results match with FLOPS outputs. But the computation algorithm of bending material factor is a little bit different in the second case. As a result, wing mass and structure mass are a little different too. The comparison is as follows:
CSV data input based unit tests are added. This is the first time that we use CSV input deck for premission unit test in
test_flops_based_premission.py.Related Issues
Backwards incompatibilities
None
New Dependencies
None