BWB components in mass/flops_based subsysterms #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alculated_wing_area'.
…s_weight in Aviary.
…ASS, set 'WTIN.NPT' for FLOPS for Aircraft.CrewPayload.Design.NUM_TOURIST_CLASS. In this way, fortran_to_aviary can read in NPF and NPT.
… length computation so that they allow zero aeras and have smooth partials
…cal tail and canard. This work will affect to SPANHT, CRTHTB, SPANVT, and CROTVT. When area and/or aspect_ratio are zero, we will get infinity partials.
jkirk5
requested changes
Dec 31, 2025
jkirk5
requested changes
Jan 5, 2026
jkirk5
requested changes
Jan 9, 2026
Contributor
jkirk5
left a comment
jkirk5
left a comment
There was a problem hiding this comment.
A few more minor change requests
| 'Suggest use detailed laylout algorithm.' | ||
| raise UserWarning( | ||
| 'Passenger compartment length is longer than recommended maximum' | ||
| ' length. Suggest using detailed laylout algorithm.' |
Contributor
There was a problem hiding this comment.
Suggested change
| ' length. Suggest using detailed laylout algorithm.' | |
| ' length. Suggest using detailed layout algorithm.' |
Comment on lines
+468
to
+469
| 'Passenger compartment lenght is longer than recommended maximum' | ||
| ' length. Suggest using detailed laylout algorithm.' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Passenger compartment lenght is longer than recommended maximum' | |
| ' length. Suggest using detailed laylout algorithm.' | |
| 'Passenger compartment length is longer than recommended maximum' | |
| ' length. Suggest using detailed layout algorithm.' |
| if rear_spar_percent_chord <= 0.0: | ||
| if verbosity > Verbosity.BRIEF: | ||
| print('Rear_spar_percent_chord must be positive.') | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
Remove the verbosity check before raising the error
| wingspan = inputs[Aircraft.Wing.SPAN][0] | ||
| if wingspan <= 0.0: | ||
| if verbosity > Verbosity.BRIEF: | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
Another error behind a verbosity check, remove the check
| if rear_spar_percent_chord <= 0.0: | ||
| if verbosity > Verbosity.BRIEF: | ||
| print('Rear_spar_percent_chord must be positive.') | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
Don't raise error behind verbosity check!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the mass subsystem for BWB aircraft. The BWB components are:
BWBFurnishingsGroupMass(vs.TransportFurnishingsGroupMass)BWBFuselageMass(vs.TransportFuselageMass)BWBAftBodyMass(new for BWB)BWBWingMiscMass(vs.WingMiscMass)BWBDetailedWingBendingFact(vs.DetailedWingBendingFact)Unit testings against these new components are added. All the results are compared to FLOPS Fortran code runs.
There are two features to know:
So, theoretically, we should have four test cases: simple layout + simple wing, simple layout + detailed wing, detailed layout + simple wing, and detailed layout + detailed wing. In this PR, however, we only have two test cases: simple layout + simple wing (see
models/aircraft/blended_wing_body/bwb_simple_FLOPS_data.py), and detailed layout + detailed wing (seemodels/aircraft/blended_wing_body/bwb_detailed_FLOPS_data.py).In
anti_icing.pyandstarter.py, nacelle average diameter (Aircraft.Nacelle.AVG_DIAMETER) is scaled by thrust ratio defined by:Aircraft.Engine.SCALED_SLS_THRUST / Aircraft.Engine.REFERENCE_SLS_THRUSTin order to match with FLOPS runs. In the current test cases, this ratio has been always 1.
Related Issues
Backwards incompatibilities
None
New Dependencies
None