chore: formalize and test conformance test file naming#115
Open
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Open
chore: formalize and test conformance test file naming#115crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Conversation
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
mwiebe
reviewed
Feb 19, 2026
|
|
||
| When both `.invalid` and `.test` are present, `.invalid` comes first: `1.1--desc.invalid.test.yaml` | ||
|
|
||
| Each extension spec should use a short, consistent prefix (e.g., `chunk` for TASK_CHUNKING, `redact` for REDACTED_ENV_VARS). The base [Template Schema](../wiki/2023-09-Template-Schemas.md) needs no prefix — a leading number implies it. |
Contributor
There was a problem hiding this comment.
The redaction and chunk extensions add language to the existing spec though, they don't introduce any new ones. Shouldn't the chunk-3.4.1.5-* just be 3.4.1.5-* still?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced the conformance test suite recently. It has a directory and file name structure convention but:
This PR fully documents the structure, adds filename prefixes for extensions, adds an automated test to ensure the tests follow the prescribed structure, and renames some extension tests to match the new scheme. The automated test will ensure test additions follow existing patterns.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.