fix: specify that amount and attribute names must be unique#110
Open
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Open
fix: specify that amount and attribute names must be unique#110crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
crowecawcaw wants to merge 1 commit intoOpenJobDescription:mainlinefrom
Conversation
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec currently does not require amount and attribute names in a step's host requirements to be unique. Having duplicate names is non-sensical though. This PR clarifies the spec.
This change is being raised as a simple bug fix PR instead of an RFC. While in a abstract sense these additional constraints change the spec, practically duplicated amount or attribute names would have undefined behavior in the system running the job, and any duplicates most likely represent a mistake in the template.
The specific wording is borrowed from job environments: https://github.com/OpenJobDescription/openjd-specifications/blob/mainline/wiki/2023-09-Template-Schemas.md#11-job-template
Fixes: #55
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.