fix: reject path separators in embedded filenames#264
Merged
epmog merged 1 commit intoOpenJobDescription:mainlinefrom Feb 13, 2026
Merged
fix: reject path separators in embedded filenames#264epmog merged 1 commit intoOpenJobDescription:mainlinefrom
epmog merged 1 commit intoOpenJobDescription:mainlinefrom
Conversation
mwiebe
approved these changes
Feb 11, 2026
epmog
approved these changes
Feb 13, 2026
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
epmog
force-pushed
the
fix-embedded-filename-path
branch
from
660bda6 to
978a19d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Spec says embedded filenames should not contain path separators, but this package allows them.
§6.1
<EmbeddedFileText>What was the solution? (How)
Fix the validator.
What is the impact of this change?
Embedded filenames are correctly validated.
How was this change tested?
Added unit tests and ran against the conformance test suite: OpenJobDescription/openjd-specifications#103
Was this change documented?
n/a
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.