-
Notifications
You must be signed in to change notification settings - Fork 3
Add Nico Piel as maintainer #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Nico Piel as maintainer #36
Conversation
34493ff to
1e16575
Compare
Signed-off-by: Jon Bartels <jon.bartels@teladochealth.com>
1e16575 to
a5bf8a8
Compare
tonygermano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comment still stands. #34 (comment)
However, I did just speak with Nico one week ago to guage his interest in becoming a maintainer since I saw him being more active, as you mentioned, and we discussed directing some of his attention towards completing code reviews if he wanted to become a maintainer. I think that's a key area in distinguishing between maintainer and contributor roles.
tonygermano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm comfortable approving now. I think Nico will make a great addition to the team.
kayyagari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nico appears to be a motivated and determined contributor. And I hope to join hands in his Gradle effort.
|
We should establish the maintainers guide first. |
This is based on PR #35 . PR #34 was split up so that we could discuss each nomination separately.
Nico has become much more active in Discord, PRs, and issues