fix: remote conversation OTEL session ID not respected #1780
+288
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1390 - Remote conversation OTEL session ID not respected in Laminar tracing.
Problem:
For remote conversations, the OTEL/Laminar observability span was being started on the client side (
remote_conversation.py), but LLM calls happen on the server side (conversation_service.py). Since OTEL context doesn't propagate across HTTP/WebSocket boundaries, traces were not properly associated with the conversation session.Solution:
start_active_span()inconversation_service.pywhen starting a conversation on the serverend_active_span()inconversation_service.pywhen deleting a conversationremote_conversation.pysince they created orphan tracesFiles changed:
openhands-agent-server/openhands/agent_server/conversation_service.pyopenhands-sdk/openhands/sdk/conversation/impl/remote_conversation.pyChecklist