Clarify exit code behavior in Hyvä compatibility checker documentation #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dermatz <6103201+dermatz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Hyvä compatibility checker command based on feedback
Clarify exit code behavior in Hyvä compatibility checker documentation
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the Hyvä compatibility checker command stated "Returns exit code 1 if critical issues found, 0 otherwise" but didn't clarify that warnings alone don't trigger a non-zero exit code.
Changes
docs/commands.mdto explicitly state that warnings without critical issues return exit code 0The command implementation (lines 214-216 of
CompatibilityCheckCommand.php) returnsRETURN_FAILUREonly when$results['summary']['criticalIssues'] > 0. This distinction matters for CI/CD pipelines that use exit codes to determine build status.- Returns exit code 1 if critical issues are found, 0 otherwise (even if warnings exist)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.