Fixes and cleanup script#128
Merged
coffandro merged 12 commits intoOpenFilamentCollective:mainfrom Jan 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses several bugs and adds significant new functionality to the Open Filament Database project. It fixes a WebUI ID generation bug, resolves an edge case in the update profiles workflow, removes a temporary migration script, implements automatic data sorting, and adds a comprehensive validation feedback system to the WebUI.
Changes:
- Fixed ID generation bug in WebUI by adding hyphen and space replacement logic
- Added conditional checks to prevent update_profiles workflow from running on pull requests
- Removed temporary
migrate_schema.pyscript after schema migration completion - Implemented
sort_data.pyscript with progress reporting and validation integration - Added validation and sort API endpoints with SSE streaming for real-time progress updates
- Created comprehensive UI components for validation feedback and data sorting
- Enhanced data_validator.py with JSON output and progress modes for WebUI integration
- Updated extensive documentation across multiple guide files
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| webui/src/lib/globalHelpers.ts | Fixed ID generation with additional character replacements (contains bug) |
| .github/workflows/update_profiles.yaml | Added condition to prevent running on PRs |
| scripts/migrate_schema.py | Removed temporary schema migration script |
| scripts/sort_data.py | New comprehensive data sorting script with schema-based key ordering |
| webui/src/routes/api/validate/+server.ts | New validation API endpoint with job management |
| webui/src/routes/api/sort/+server.ts | New sort API endpoint with job management |
| webui/src/routes/api/validate/stream/[jobId]/+server.ts | SSE streaming endpoint for validation progress |
| webui/src/routes/api/sort/stream/[jobId]/+server.ts | SSE streaming endpoint for sort progress |
| webui/src/lib/server/jobManager.ts | Job tracking system with automatic cleanup |
| webui/src/lib/hooks/useSSE.ts | SSE client hook for real-time updates |
| webui/src/lib/stores/validationStore.ts | Validation state management store |
| webui/src/lib/utils/pathToRoute.ts | Path-to-route conversion for navigation |
| webui/src/lib/components/ValidationTriggerButton.svelte | Validation trigger UI component |
| webui/src/lib/components/ValidationProgressModal.svelte | Progress modal for long-running operations |
| webui/src/lib/components/ValidationDropdown.svelte | Validation errors dropdown display |
| webui/src/lib/components/SortDataButton.svelte | Sort data trigger UI component |
| webui/src/routes/+layout.svelte | Layout updated with validation and sort controls |
| data_validator.py | Enhanced with JSON output and progress reporting |
| docs/webui.md | Comprehensive documentation of validation and sorting features |
| docs/validation.md | Updated validation guide with WebUI and CLI instructions |
| docs/pull-requesting.md | Updated PR guide emphasizing validation and sorting |
| docs/manual.md | Improved manual contribution guide |
| docs/installing-software.md | Minor documentation improvements |
| docs/forking.md | Enhanced forking instructions |
| docs/cloning.md | Improved cloning guide |
| README.md | Updated with validation and sorting workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes (vault) #111