Skip to content

Fixes and cleanup script#128

Merged
coffandro merged 12 commits intoOpenFilamentCollective:mainfrom
coffandro:fixes_and_cleanup_script
Jan 10, 2026
Merged

Fixes and cleanup script#128
coffandro merged 12 commits intoOpenFilamentCollective:mainfrom
coffandro:fixes_and_cleanup_script

Conversation

@coffandro
Copy link
Collaborator

@coffandro coffandro commented Jan 10, 2026

This PR:

Fixes (vault) #111

@coffandro coffandro marked this pull request as ready for review January 10, 2026 16:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses several bugs and adds significant new functionality to the Open Filament Database project. It fixes a WebUI ID generation bug, resolves an edge case in the update profiles workflow, removes a temporary migration script, implements automatic data sorting, and adds a comprehensive validation feedback system to the WebUI.

Changes:

  • Fixed ID generation bug in WebUI by adding hyphen and space replacement logic
  • Added conditional checks to prevent update_profiles workflow from running on pull requests
  • Removed temporary migrate_schema.py script after schema migration completion
  • Implemented sort_data.py script with progress reporting and validation integration
  • Added validation and sort API endpoints with SSE streaming for real-time progress updates
  • Created comprehensive UI components for validation feedback and data sorting
  • Enhanced data_validator.py with JSON output and progress modes for WebUI integration
  • Updated extensive documentation across multiple guide files

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
webui/src/lib/globalHelpers.ts Fixed ID generation with additional character replacements (contains bug)
.github/workflows/update_profiles.yaml Added condition to prevent running on PRs
scripts/migrate_schema.py Removed temporary schema migration script
scripts/sort_data.py New comprehensive data sorting script with schema-based key ordering
webui/src/routes/api/validate/+server.ts New validation API endpoint with job management
webui/src/routes/api/sort/+server.ts New sort API endpoint with job management
webui/src/routes/api/validate/stream/[jobId]/+server.ts SSE streaming endpoint for validation progress
webui/src/routes/api/sort/stream/[jobId]/+server.ts SSE streaming endpoint for sort progress
webui/src/lib/server/jobManager.ts Job tracking system with automatic cleanup
webui/src/lib/hooks/useSSE.ts SSE client hook for real-time updates
webui/src/lib/stores/validationStore.ts Validation state management store
webui/src/lib/utils/pathToRoute.ts Path-to-route conversion for navigation
webui/src/lib/components/ValidationTriggerButton.svelte Validation trigger UI component
webui/src/lib/components/ValidationProgressModal.svelte Progress modal for long-running operations
webui/src/lib/components/ValidationDropdown.svelte Validation errors dropdown display
webui/src/lib/components/SortDataButton.svelte Sort data trigger UI component
webui/src/routes/+layout.svelte Layout updated with validation and sort controls
data_validator.py Enhanced with JSON output and progress reporting
docs/webui.md Comprehensive documentation of validation and sorting features
docs/validation.md Updated validation guide with WebUI and CLI instructions
docs/pull-requesting.md Updated PR guide emphasizing validation and sorting
docs/manual.md Improved manual contribution guide
docs/installing-software.md Minor documentation improvements
docs/forking.md Enhanced forking instructions
docs/cloning.md Improved cloning guide
README.md Updated with validation and sorting workflow

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 7 comments.

@coffandro coffandro merged commit 7e7595b into OpenFilamentCollective:main Jan 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments