Skip to content

v0.2.0 mergeback: 01-09-2026 bincode CI regression #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tullom merged 2 commits into from
Jan 9, 2026
Merged

v0.2.0 mergeback: 01-09-2026 bincode CI regression #672

tullom merged 2 commits into from
Jan 9, 2026

Conversation

@tullom
Copy link
Contributor

@tullom tullom commented Jan 9, 2026 •
edited
Loading

Mergeback commit c7f8e86 from #669 into v0.2.0 , which is failing CI.

@tullom
Add temporary exception for bincode in deny.toml (OpenDevicePartnersh…
66c758d 
…ip#669)

I saw a regression in our stable/deny CI job. The `bincode` crate is
unmaintained and ⁠[it has just been marked as
such](rustsec/advisory-db#2574).

This PR adds an exception to our deny.toml to unblock our CI for now,
but we should try to migrate to another serde crate like postcard soon.

Luckily only 2 of our crates use bincode so migration is
straightforward:

-
[⁠embedded-usb-pd](https://github.com/OpenDevicePartnership/embedded-usb-pd)
- [tps6699x](https://github.com/OpenDevicePartnership/tps6699x)
@tullom tullom self-assigned this Jan 9, 2026
@tullom tullom marked this pull request as ready for review January 9, 2026 19:50
@tullom tullom requested a review from a team as a code owner January 9, 2026 19:50
@tullom tullom enabled auto-merge (squash) January 9, 2026 19:51
@tullom tullom requested a review from williampMSFT January 9, 2026 19:52
@tullom tullom merged commit 2e46e77 into OpenDevicePartnership:v0.2.0 Jan 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurtjd kurtjd kurtjd approved these changes

@williampMSFT williampMSFT williampMSFT approved these changes

@RobertZ2011 RobertZ2011 Awaiting requested review from RobertZ2011 RobertZ2011 is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@jerrysxie jerrysxie Awaiting requested review from jerrysxie jerrysxie is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@gjpmsft gjpmsft Awaiting requested review from gjpmsft gjpmsft is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@madeleyneVaca madeleyneVaca Awaiting requested review from madeleyneVaca madeleyneVaca is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

Assignees

@tullom tullom

Labels

mergeback

Projects

Embedded Controller
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tullom @kurtjd @williampMSFT