CI improvements and miscellaneous feedback #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wassasin
force-pushed
the
fix/feedback
branch
2 times, most recently
from
8eb700c to
4bdf4e5
Compare
Wassasin
changed the title
… yaml is a superset of json
felipebalbi
approved these changes
Oct 8, 2025
jerrysxie
approved these changes
Oct 8, 2025
Contributor
jerrysxie
left a comment
jerrysxie
left a comment
There was a problem hiding this comment.
We can merge in this first. We will fix up the cargo deny for bootloader-tool in a follow-up PR. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing feedback from PR #19:
logfeature not compiling for /libs (added to CI as well)Nconst parameter toBLOCK_SIZEand explained what it is for.device-drivergenerated manifest and fixed building in CI.bootloader-tool.bootloader-toolto CI, with exception ofcargo deny.serde_yamland useserde_jsoninstead forbootloader-tool. (we are only serializing, and yaml is a superset of json)