Etape-3 #39
Open
Etape-3 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er with local variables
…ll 2 time logic into he mehtod
…method Simplify stream.filter...count == 0 into noneMatch method Modify privates List VisitedLocation and UserReward into copyOnWriteArrayList Simplify addUserReward because always return true
etape-2 doned
…easely withtout implement to much logic into the conroller class
…ing to much code into the new method getNearByAttractionDtos (TourGuideService)
…tions Add new getNearByAttractionDtos method to use it into TourGuideController where it returns the five closest attraction from user
…ce.getNearByAttractionDtos and return a complete object NearAttractionDto
etape-3
TourguideApplication -> TourGuideApplication
…Classe Added new method to use trackUserLocation as an Asynchrone method
…Classe Added new method to use calculateRewards as an Asynchrone method
highVolumeTrackLocation: replaced for User user : allUsers by calling our new TourGuideService method trackAllUsersLocation highVolumeGetRewards: replaced allUsers.forEach(u -> rewardsService.calculateRewards(u)); by calling our new RewardsService method calculateAllUsersRewards
…RewardsService Change availableProcessor into 100 poolThread to be quicker RewardsService and TourGuideService
Simplify allUsers variable and correct redondance warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etape 3 doned
TODO into TourGuideController and new logic are doned and implemented