fix unused down_sample:voxel_m parameter #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leaf size used for downsampling was using magic number instead of
down_sample:voxel_mparameter from json config file, this change fixes it.Additionally:
kLeafSizetoleafSizeask*variables are reserved for global/static constants, which json parameter is not as it is dynamically assigned.const doubleas the value is not changed later andpcl::octree::OctreePointCloudconstructor takesdouble.