Skip to content

Warn on zero-bufcnt target (based on v87pre3) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecashin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Warn on zero-bufcnt target (based on v87pre3) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a51c56
AoE target developers cannot tell why out-of-spec 0-bufcnt targets fail
ecashin Mar 18, 2016
12d243d
Update URL to point to OpenAoE project aoe repo
ecashin Mar 18, 2016
5806614
Avoid zero congestion window for bufcnt of one
ecashin Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The version number of this driver is unrelated to the version numbers
of Linux kernels. Just use the latest aoe driver with your 2.6 or 3.x
Linux kernel.

[This driver is available on github.](https://github.com/ecashin/aoe)
[This driver is available on github.](https://github.com/OpenAoE/aoe)

Please see linux/Documentation/aoe.txt for basic information and
EtherDrive-2.6-HOWTO.sgml for more.
Expand Down
8 changes: 7 additions & 1 deletion linux/drivers/block/aoe/aoecmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,8 @@ addtgt(struct aoedev *d, char *addr, ulong nframes)
memcpy(t->addr, addr, sizeof t->addr);
t->ifp = t->ifs;
aoecmd_wreset(t);
t->maxout = t->nframes / 2;
if (t->nframes > 1)
t->maxout = t->nframes / 2;
INIT_LIST_HEAD(&t->ffree);
return *tt = t;

Expand Down Expand Up @@ -1653,6 +1654,11 @@ aoecmd_cfg_rsp(struct sk_buff *skb)
n = be16_to_cpu(ch->bufcnt);
if (n > aoe_maxout) /* keep it reasonable */
n = aoe_maxout;
else if (n == 0) {
pr_warn_ratelimited("aoe: e%ld.%d has zero bufcnt %s\n",
aoemajor, h->minor, "and cannot be used");
return;
}

d = aoedev_by_aoeaddr(aoemajor, h->minor, 1);
if (d == NULL) {
Expand Down