Skip to content

Conversation

@abrichr
Copy link
Member

@abrichr abrichr commented Jan 17, 2026

Summary

Adds a GitHub Actions CI workflow (test.yml) for automated testing on pull requests and main branch pushes.

Changes

  • New workflow: .github/workflows/test.yml

    • Runs tests on Python 3.10 and 3.11
    • Tests on both Ubuntu and macOS runners
    • Uses uv for fast dependency management
    • Runs pytest (115 tests)
    • Runs ruff linter and formatter checks (non-blocking)
  • Code quality improvements: Fixed multiple ruff linting issues

    • Removed unused imports in example files
    • Removed unnecessary f-string prefixes
    • Fixed ambiguous variable names
    • Removed unused variable assignments

Test Plan

  • All 115 pytest tests pass locally
  • Workflow file syntax is valid
  • CI workflow runs successfully on GitHub Actions (will verify after PR creation)

Notes

  • Linting checks are set to continue-on-error: true to allow iteration on code quality without blocking CI
  • Some Python 3.12 syntax issues remain in component files (f-string escaping) that will need separate fixes for full Python 3.10 compatibility
  • The workflow follows the pattern used in other OpenAdapt repositories (openadapt-ml, OpenAdapt)

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

@abrichr
Copy link
Member Author

abrichr commented Jan 18, 2026

This PR has merge conflicts that need to be resolved. The CI workflow addition looks good and follows the pattern used in other OpenAdapt repositories.\n\nNext steps:\n1. Resolve merge conflicts with main branch\n2. Verify CI workflow runs successfully after resolving conflicts\n3. Consider addressing the Python 3.12 syntax issues mentioned in the PR description (f-string escaping)\n\nThis is recent work (Jan 17) and should be merged soon after conflicts are resolved.

- Add test.yml workflow that runs on PRs and main branch pushes
- Test on Python 3.10 and 3.11 across ubuntu-latest and macos-latest
- Use uv for fast dependency management
- Run pytest and ruff linter/formatter checks
- Linting checks are non-blocking to allow iteration on code quality
- Fix multiple ruff linting issues (unused imports, f-string placeholders, ambiguous variable names)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@abrichr abrichr force-pushed the ci/add-test-workflow branch from d3ce722 to 5da7114 Compare January 19, 2026 00:06
@abrichr abrichr merged commit 8b49ed2 into main Jan 19, 2026
1 of 5 checks passed
@abrichr abrichr deleted the ci/add-test-workflow branch January 19, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants