Skip to content

Refine CLI #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomaslepoix merged 15 commits into from
Nov 28, 2025
Merged

Refine CLI #31

thomaslepoix merged 15 commits into from
Nov 28, 2025

Conversation

@thomaslepoix
Copy link
Member

@thomaslepoix thomaslepoix commented Nov 24, 2025 •
edited
Loading

This, along with other minor improvements and refactorings, mainly implements some progress bars to monitor the process in case of large files, both in the GUI and in the CLI.

Trying instructions:

nix develop
	cmake -S . -B build
	cmake --build build #-j
	build/src/openemsh_bin -h
  • Observe the command line help.
	build/src/openemsh_bin -G -v --lmin 2
  • Tile the terminal and the GUI side by side.
  • Open a file that is complex enough to process: [CTRL]+[O] -> test/run_dual_dipole.xml.
  • Observe the bars on both sides.
  • Edit global parameters by double-clicking somewhere in the Processing view and set dmax to 500 and observe again.

@thomaslepoix thomaslepoix added this to the 0.0.1 milestone Nov 24, 2025
@thomaslepoix thomaslepoix added the CLI Command Line Interface label Nov 24, 2025
@thomaslepoix thomaslepoix mentioned this pull request Nov 24, 2025
Closed
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 25, 2025
View reviewed changes
src/domain/board.cpp
//******************************************************************************
void Board::add_fixed_meshline_policies(Axis axis) {
auto [bar, i, _] = Progress::Bar::build(
fixed_meshline_policy_creators[axis].size(),

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
src/domain/conflict_manager.cpp
//******************************************************************************
void ConflictManager::auto_solve_all_edge_in_polygon(Plane const plane) {
for(auto const& conflict : get_current_state().all_edge_in_polygons[plane])
auto [bar, i, _] = Progress::Bar::build(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
src/domain/conflict_manager.cpp
//******************************************************************************
void ConflictManager::auto_solve_all_colinear_edges(Axis const axis) {
for(auto const& conflict : get_current_state().all_colinear_edges[axis])
auto [bar, i, _] = Progress::Bar::build(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
src/domain/meshline_policy_manager.cpp

// // TODO C++26 already implemented
// auto [bar, _, _] = Progress::Bar::build(
auto [bar, _, __] = Progress::Bar::build(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
src/domain/meshline_policy_manager.cpp

// // TODO C++26 already implemented
// auto [bar, _, _] = Progress::Bar::build(
auto [bar, _, __] = Progress::Bar::build(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable __ is not used.
src/domain/meshline_policy_manager.cpp

auto dimension_view = create_view(state.intervals[axis]);

auto [bar, i, _] = Progress::Bar::build(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable _ is not used.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2025
View reviewed changes
src/infra/parsers/parser_from_csx.cpp
for(auto const& node : primitive.node().children()) {
pimpl->primitives_ids.emplace(node, id++);
cerr << node.name() << endl;
// cerr << node.name() << endl;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@thomaslepoix thomaslepoix linked an issue Nov 28, 2025 that may be closed by this pull request
Complete CLI #9
Closed
2 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
44.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@thomaslepoix thomaslepoix merged commit ee0ee5e into main Nov 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLI Command Line Interface

Projects

None yet

Milestone

0.0.1

Development

Successfully merging this pull request may close these issues.

Complete CLI

2 participants

@thomaslepoix