add fused_fast_gelu_mul #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiezipeng-ML
requested review from
BBuf and
oneflow-ci-bot
and removed request for
oneflow-ci-bot
BBuf
reviewed
Mar 20, 2023
| return hidden_states | ||
|
|
||
|
|
||
| def test_fused_self_attention(): |
BBuf
reviewed
Mar 20, 2023
| from oneflow_onnx.oneflow2onnx.util import convert_to_onnx_and_check | ||
|
|
||
|
|
||
| class FusedFastGelu(flow.nn.Module): |
Contributor
There was a problem hiding this comment.
这些地方的FusedFastGelu都改成FusedFastGeluMulMT5吧，减少和oneflow._C.fast_gelu的语意冲突可能
BBuf
approved these changes
Mar 20, 2023
xiezipeng-ML
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
xiezipeng-ML
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
xiezipeng-ML
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.