drivers: media: msm: don't use nested functions #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang doesn't support nested functions, and there's no compelling reason that these functions need to have such a restricted scope. Change-Id: I698f7b19de8f6dff46a717403c1f518446748b18 Signed-off-by: Greg Hackmann <ghackmann@google.com> Link: https://android.googlesource.com/kernel/msm/+/a7812babae94ac48da09e7e967c0b55d24a77994 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang doesn't support nested functions, and there's no compelling reason
that these functions need to have such a restricted scope.
Change-Id: I698f7b19de8f6dff46a717403c1f518446748b18
Signed-off-by: Greg Hackmann ghackmann@google.com
Link: https://android.googlesource.com/kernel/msm/+/a7812babae94ac48da09e7e967c0b55d24a77994
Signed-off-by: Nathan Chancellor natechancellor@gmail.com