Skip to content
This repository was archived by the owner on Mar 1, 2025. It is now read-only.

Conversation

@cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Oct 22, 2024

Needs fixing for Windows.

Don't know if this is change is wanted but I was interested to see because when I run locally I get:

 11 - OndselSolver.Gears (Subprocess aborted)
 12 - OndselSolver.anglejoint (Subprocess aborted)
 13 - OndselSolver.constvel (Subprocess aborted)
 14 - OndselSolver.rackscrew (Subprocess aborted)
 15 - OndselSolver.planarbug (Subprocess aborted)
 18 - OndselSolver.piston (Subprocess aborted)

Copy link
Contributor

@chennes chennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always think it's a good idea to run your test suite as part of your CI, so I think this is a clear improvement.

@PaddleStroke
Copy link
Contributor

@chennes any idea what the failing checks means? Is it still safe to merge?

@chennes
Copy link
Contributor

chennes commented Jan 22, 2025

I probably wouldn't merge it until you've run the tests locally in a debugger and figured out what is segfaulting. The fact that it's happening on all of the CI platforms generally indicates that the problem is real.

@cjmayo
Copy link
Contributor Author

cjmayo commented Jan 22, 2025

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants