Close connection when connecting to server fails#15
Open
raman325 wants to merge 1 commit intoOnFreund:masterfrom
Open
Close connection when connecting to server fails#15raman325 wants to merge 1 commit intoOnFreund:masterfrom
raman325 wants to merge 1 commit intoOnFreund:masterfrom
Conversation
Owner
|
Thanks @raman325. Did you test this? |
Contributor
Author
|
I was not able to see this issue on my system so I wasn't able to test that it fixed the issue. Perhaps we could ask someone from one of those old threads to check? |
Owner
|
Yeah, I think that would be best |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was fixing a bug with the HA integration when I was pointed to this ticket: home-assistant/core#67954
A brief look at the code says that the websockets are managed entirely within this package. If that's true, this is the only place where I see a leak of connections could be possible.