update & fix bspwm block #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Jasek <tomsik68@gmail.com>
Signed-off-by: Tomas Jasek <tomsik68@gmail.com>
Signed-off-by: Tomas Jasek <tomsik68@gmail.com>
Owner
|
Brilliant, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bspwm JSON format has changed and bspwm block does not detect focused desktop properly. There was already an attempt to fix this(see #31), but that does not fix issue with primary monitor detection and travis didn't pass on the PR.
I updated the mock json string used by tests to reflect what is returned by bspwm 0.9.2 and then fixed the block so that all tests are passing again.
It's worth to mention I'm currently running this version of gem on my bspwm 0.9.2 desktop just fine.
P.S. Thanks for this project, I love configuring lemonbar via ruby :)