Draft
Conversation
- Remove unnecessary encodeURIComponent() on track IDs (they only contain safe chars) - Use actual commas in join() instead of literal '%2C' string - Remove legacy trailing dot/comma cleanup that could interfere with URLs - Add trim() and empty check in URL parser for robustness - Fixes the '%2E%2C' appearing instead of commas - Fixes last category being dropped from shared URLs Co-authored-by: Shane <OfficiallySp@users.noreply.github.com>
- Swap heartsteel_late_drums.aac <-> illbeats_late.aac (contents were reversed) - Move hyperpop_late_drums.aac -> truedamage_late_drums.aac (file contained True Damage audio) - Remove hyperpop_late_drums from tracks array and UI (track doesn't exist in game) - Update presets referencing hyperpop_late_drums to use truedamage_late_drums - Fixes Chinese-reported issue about Maestro/Heartsteel drum beats being swapped Co-authored-by: Shane <OfficiallySp@users.noreply.github.com>
- In real-time mode, load ALL tracks (not just checked ones) so they can be toggled on/off - This fixes the index mismatch where toggleTrackRealTime() used global track indices but audioGainArray only had entries for checked tracks - Unchecked tracks start with gain=0 and can be toggled to gain=1 in real-time - Clear activeTrackElements when toggling real-time mode to force reload - The '(longer load on play)' label now correctly reflects the behavior Co-authored-by: Shane <OfficiallySp@users.noreply.github.com>
- Add progress bar showing current playback position with seeking - Add current time / total time display - Add restart (replay from beginning) button - Add skip forward/backward buttons (10 second jumps) - Progress bar updates in real-time using requestAnimationFrame - Seeking stops and restarts playback at the new position - Control center appears when tracks start playing - Properly handles repeat mode and real-time mode - Fix all startCallback reuse paths to properly set up masterGainNode and timing Co-authored-by: Shane <OfficiallySp@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for tftmixer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues including shareable link encoding, swapped audio files, real-time mixing logic, and adds a playback control center.
This PR addresses several open issues:
encodeURIComponenton track IDs and using actual commas for joining, along with making the URL parser more robust.heartsteel_late_drums.aacandillbeats_late.aac, and movedhyperpop_late_drums.aactotruedamage_late_drums.aac(as it contained True Damage audio), updating all references and removing the non-existent Hyperpop track.toggleTrackRealTime()andaudioGainArray.