Draft
Conversation
- Fix typos: 'eachover' -> 'each other', 'througout' -> 'throughout' - Fix broken URL links: add https:// protocol to migration alert links - Fix Country icon alt text: '8bit' -> 'Country' - Fix invalid HTML: remove h4 from inside label for Global Volume - Add viewport meta tag for mobile responsiveness - Fix toggleTrackRealTime: use track element to find correct index in activeTrackElements (was using wrong index from tracks array) - Fix applyPreset: only clear track checkboxes, preserve Real Time/Repeat settings - Fix applyPreset: dispatch change events for proper real-time mode support Co-authored-by: Shane <OfficiallySp@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for tftmixer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple UI/UX, accessibility, and functional issues, including a bug in Real Time track toggling and improving preset application.
The
toggleTrackRealTimefunction was incorrectly using an index from the fulltracksarray against theactiveTrackElementsarray (which only contains checked tracks), leading to incorrect gain node updates. The fix passes the track element directly and finds its correct index withinactiveTrackElements. Additionally,applyPresetnow dispatches change events to ensure Real Time mode responds correctly.