Changes to the TeamMemberCard Molecule Component b OleanjiKingCode #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OleanjiKingCode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the TeamMemberCard Molecule Component
Summary
Improved the UI to manage longer text in the card
Details
Truncated the long text of the header by using eclipsis
How to test it
Inorder to test this you will need to have the project locally then run
yarn storybookalso note you will need to be using node version 16nvm use 16.x.xScreenshots (Current Changes)
-Before the changes:
This is how the storybook results look : https://we.tl/t-aguj8Zg4jA
ticket: #000
This PR does not have any ticket attached to it as this is an attempt to improve the Team Member Card like I said in my previous pr for obol-site
how's this @f1lander @german-bortoli @Arash-Afshar ; I hope this is in flow with the design