feat: add mariadb logical backup #46
Conversation
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
ef4503b to
6926f45
Compare
| gcc \ | ||
| libffi-dev \ | ||
| && curl -sL https://aka.ms/InstallAzureCLIDeb | bash \ | ||
| && pip3 install --upgrade pip \ |
There was a problem hiding this comment.
we need to pin to a version, so next image build will have same version of pip
There was a problem hiding this comment.
made the changes in both postgres and mariadb logical backup dockerfiles
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
4c9938c to
525fc7b
Compare
postgres-logical-backup/dump.sh
Outdated
| az_upload /tmp/azure-backup.sql.gz | ||
| else | ||
|
|
||
| # Backup all the databases owned by the user if PGDATABASE is not set |
There was a problem hiding this comment.
F.ex in opendesk multiple apps use the same postgres instance with different users. This handles that.
There was a problem hiding this comment.
have removed these, as found a few more changes required. Will raise a separate PR for that.
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
525fc7b to
70372ee
Compare
anantha1999
changed the title
postgres-logical-backup/dump.sh
Outdated
|
|
||
| echo "Uploading dump to s3" | ||
| aws s3 cp - "$PATH_TO_BACKUP" "${args[@]//\'/}" | ||
| aws s3 cp - "$PATH_TO_BACKUP" "${args[@]}" |
There was a problem hiding this comment.
fixes below
Uploading dump to s3
fatal error: invalid literal for int() with base 10: '34613139 --endpoint-url=http://localhost:9000 --region=us-west-1'
There was a problem hiding this comment.
have removed these, as found a few more changes required. Will raise a separate PR for that.
postgres-logical-backup/dump.sh
Outdated
| "$PG_BIN"/pg_dump --verbose | ||
| else | ||
| "$PG_BIN"/pg_dumpall --exclude-database='postgres' | ||
| "$PG_BIN"/pg_dumpall --exclude-database='postgres' --verbose |
There was a problem hiding this comment.
added verbose for logs in the cronjob
There was a problem hiding this comment.
have removed these, as found a few more changes required. Will raise a separate PR for that.
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
70372ee to
27a28ec
Compare
anantha1999
changed the title
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
27a28ec to
580f06b
Compare
anantha1999
force-pushed
the
mariadb-logical-backup
branch
from
580f06b to
1e23dac
Compare
No description provided.