Skip to content

Create an audit log for objects (attempt #2) #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
drkitty wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Create an audit log for objects (attempt #2) #944

drkitty wants to merge 49 commits into from

Conversation

@drkitty
Copy link
Contributor

@drkitty drkitty commented Mar 30, 2015

Supersedes PR #755.

zeeman and others added 30 commits August 22, 2014 15:08
@zeeman
Get logging working. (No UI stuff)
695a572
@zeeman
User can view changes to Dynamic Interface.
3ea399b
@zeeman
Log the actual user making a change instead of the user they've become
bd63fe6
@zeeman
Add logging to all cydhcp models
cd1d6ae
@zeeman
Start custom DynamicInterface serializer for user-friendly logging
309c012
@zeeman
TEMP start implementing DRF-based serializers
127dfe6
@zeeman
Implement DRF-based serializers for logging, hide log fields from forms.
ca7b89b
@zeeman
Undo some dumb mistakes
3a3cbd9
@zeeman
Remove VRF logging
827236a
@zeeman
Add DRF-based serializers for logging
8b840c1
@zeeman
Remove pudb.set_trace
e8d5c82
@zeeman
TEMP? Replace log with nicer-looking table view
49375c4
@zeeman
Display only the previous values of fields that are changed.
619f3f4
@zeeman
Use nicer dates, fix various things
1ba2713
@zeeman
Add (mysteriously non-functional) CNAME detail view
2021b54
@zeeman
Attempt alternative (and also non-functional) CNAME detail view url p…
f9efb5d 
…attern
@zeeman
Add CNAME and NS detail views, attempt to add logging to view changes.
0e7828d
@zeeman
Merge branch 'master' into object_audit_log_temp
28e3de7 
Conflicts:
	cyder/cydns/address_record/forms.py
	cyder/cydns/cname/forms.py
	cyder/cydns/mx/forms.py
	cyder/cydns/nameserver/models.py
	cyder/cydns/ptr/models.py
	cyder/cydns/srv/forms.py
	cyder/cydns/sshfp/forms.py
	cyder/cydns/txt/forms.py
@zeeman
Fix bug where m2m relations were not saved.
be7d779
@zeeman
Add some extra serializer fields, enable logging when a field has bee…
fa9af0b 
…n updated from blank.
@zeeman
Add necessary DNS detail views, change how previously blank fields ar…
e740436 
…e displayed in log, fix broken SRV serializer.
@zeeman
Remove pointless fields from DynamicInterfaceLogSerializer
2a0db66
@zeeman
Don't add a log entry if no changes will be logged. Better PEP8 compl…
f8eadd3 
…iance.
@zeeman
Make serializer field names and order closer to UI.
c4c9d34
@zeeman
Make log serializers even closer to UI.
9183036
@drkitty
Merge branch 'master' into object_audit_log
c05dc9d 
Conflicts:
	cyder/base/views.py
	cyder/cydhcp/interface/dynamic_intr/models.py
	cyder/cydhcp/interface/static_intr/models.py
	cyder/cydhcp/network/models.py
	cyder/cydhcp/range/models.py
	cyder/cydhcp/site/models.py
	cyder/cydhcp/views.py
	cyder/cydhcp/vlan/models.py
	cyder/cydhcp/vrf/models.py
	cyder/cydhcp/workgroup/models.py
	cyder/cydns/address_record/models.py
	cyder/cydns/cname/models.py
	cyder/cydns/domain/forms.py
	cyder/cydns/domain/models.py
	cyder/cydns/mx/models.py
	cyder/cydns/nameserver/models.py
	cyder/cydns/nameserver/urls.py
	cyder/cydns/ptr/models.py
	cyder/cydns/soa/models.py
	cyder/cydns/srv/models.py
	cyder/cydns/sshfp/models.py
	cyder/cydns/txt/models.py
@zeeman
Merge remote-tracking branch 'drkitty/object_audit_log+master' into o…
0d89bd0 
…bject_audit_log
@zeeman
Merge branch 'master' into object_audit_log
45f99e9 
Conflicts:
	cyder/cydhcp/interface/dynamic_intr/models.py
	cyder/cydhcp/interface/static_intr/models.py
	cyder/cydhcp/network/models.py
	cyder/cydhcp/range/models.py
	cyder/cydhcp/site/models.py
	cyder/cydhcp/vlan/models.py
	cyder/cydhcp/vrf/models.py
	cyder/cydhcp/workgroup/models.py
	cyder/cydns/cname/models.py
	cyder/cydns/domain/models.py
	cyder/cydns/mx/models.py
	cyder/cydns/nameserver/models.py
	cyder/cydns/ptr/models.py
	cyder/cydns/srv/models.py
	cyder/cydns/sshfp/models.py
	cyder/cydns/txt/models.py
@zeeman
Merge branch 'master' of github.com:OSU-Net/cyder into object_audit_l…
00c4352 
…og_test_merge

Conflicts:
	cyder/cydhcp/interface/static_intr/models.py
@zeeman
Don't import settings from cyder.settings.local, improve idiomaticity
105ee6a
@drkitty
Copy link
Contributor Author

drkitty commented Apr 28, 2015

...except for the merge, which I'll take a look at

drkitty added 2 commits April 28, 2015 12:40
@drkitty
Merge remote-tracking branch 'upstream/master' into object-audit-log
83f9bed 
Conflicts:
	cyder/cydhcp/network/models.py
	cyder/cydhcp/range/models.py
	cyder/cydhcp/views.py
	cyder/cydns/nameserver/urls.py
	cyder/cydns/nameserver/views.py
	cyder/settings/local.py-travis
@drkitty
Clean up after merge
a18d837
@drkitty
Copy link
Contributor Author

drkitty commented Apr 28, 2015

The range log isn't displayed on range detail pages.

@drkitty
Copy link
Contributor Author

drkitty commented Apr 28, 2015

Same with the site log. Maybe there's a good reason to keep a log and not show it, but I don't know what it is.

@drkitty
Copy link
Contributor Author

drkitty commented Apr 28, 2015

Something's wrong with DNSForm or Django.

@drkitty
Copy link
Contributor Author

drkitty commented Apr 30, 2015

So I know this solution is gross and just adds to the mountain of ad-hoc mutation in Cyder, but we've accumulated so many workarounds for questionable Django design decisions that it would be difficult to solve this problem any other way.

@drkitty drkitty assigned murrown and unassigned akeym May 12, 2015
@murrown
Copy link
Member

murrown commented May 13, 2015

Some quick notes...

  • Systems don't track name changes
  • DNS record's views aren't tracked (perhaps all m2m fields aren't tracked?)
  • DNS record's container isn't tracked

@drkitty
Copy link
Contributor Author

drkitty commented May 14, 2015

  • That's intentional. I remember someone okaying it.
  • Probably should be fixed. I'll look into how difficult that would be.
  • Weird.

@murrown
Copy link
Member

murrown commented May 15, 2015

It wouldn't be difficult to track system names though, right? Anyone know the rationale for not tracking system names? @akeym

@murrown
Copy link
Member

murrown commented May 15, 2015

I can't update dynamic interfaces. Unknown internal server error.

BTW, this is definitely on this branch... I can update the interface on master just fine.

@akeym
Copy link
Member

akeym commented May 15, 2015

I'm not sure what the reasoning is, if any. And now that they have ctnrs...

@murrown
Copy link
Member

murrown commented May 15, 2015

Yeah, speaking of containers, that might be the reason why I can't update interfaces on this branch. Maybe my database is using the wrong schema, although I did run a schema migration to check...

@drkitty
Copy link
Contributor Author

drkitty commented May 28, 2015

Saving interfaces works again.

@drkitty
Copy link
Contributor Author

drkitty commented Jun 25, 2015

I think maybe we should just merge this and I can fix the remaining issues later.

@akeym
Copy link
Member

akeym commented Jun 25, 2015

Have we done some simple stress testing to see what happens after you
change an object more than the amount of times we track? how about
artificially making a bunch of change history :) I dunno, I really don't
want to deploy something that's broken or will make Cyder implode.

On Thu, Jun 25, 2015 at 1:42 PM, drkitty notifications@github.com wrote:

I think maybe we should just merge this and I can fix the remaining issues
later.

—
Reply to this email directly or view it on GitHub
#944 (comment).

@drkitty
Copy link
Contributor Author

drkitty commented Jun 25, 2015

Sure, I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@murrown murrown

Labels

high priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drkitty @murrown @akeym @church29 @zeeman