P1674: Changes based on PR suggestions for P1673 #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ORNL#228 by Jeff Hammond suggests changes to P1673. Some of those can be applied to P1674 as well. This PR does that.
dalg24
approved these changes
May 12, 2022
Contributor
Author
|
Thanks @dalg24 ! (I don't actually have merge permission on this repo, btw, so please feel free to merge if you think it's OK.) |
Contributor
Author
|
Thanks @dalg24 ! : - ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crtrott @dalg24 @nliber
PR #228 by Jeff Hammond suggests changes to P1673. Some of those can be applied to P1674 as well. This PR does that. I also took the opportunity to make a few minor drive-by fixes.