Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Jan 26, 2026

Proposed changes

Fix EndpointIncomingRequest to do serviceLookup at invocation time in…stead of construction. This makes the object smaller and fixes a bug where the transport channel response was not sent due to unhandled exception

Fixes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

…stead of construction. This makes the object smaller and fixes a bug where the transport channel response was not sent due to unhandled exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server] TransportChannel Response BadServiceUnsupported is never sent due to unhandled Exception when constructing EndpointIncomingRequest

3 participants