Skip to content

[Client] Modified Publish error handling to raise publish error events for BadNoSubscription if there are active subscriptions #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcschier merged 1 commit into from
Jan 27, 2026
+5 −4
Merged

[Client] Modified Publish error handling to raise publish error events for BadNoSubscription if there are active subscriptions #3502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Libraries/Opc.Ua.Client/Session/Session.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,18 +2510,18 @@ public async Task ReconnectAsync(
/// <summary>
/// Recreate the subscriptions in a recreated session.
/// </summary>
/// <param name="transferSbscriptionTemplates">Uses Transfer service
/// <param name="transferSubscriptionTemplates">Uses Transfer service
/// if set to <c>true</c>.</param>
/// <param name="subscriptionsTemplate">The template for the subscriptions.</param>
/// <param name="ct">Cancellation token to cancel operation with</param>
private async Task RecreateSubscriptionsAsync(
bool transferSbscriptionTemplates,
bool transferSubscriptionTemplates,
IEnumerable<Subscription> subscriptionsTemplate,
CancellationToken ct)
{
using Activity? activity = m_telemetry.StartActivity();
bool transferred = false;
if (transferSbscriptionTemplates)
if (transferSubscriptionTemplates)
{
try
{
Expand Down Expand Up @@ -3533,7 +3533,8 @@ private void OnPublishComplete(
// raise an error event.
var error = new ServiceResult(e);

if (error.Code != StatusCodes.BadNoSubscription)
// raise publish error even for BadNoSubscription if there are active subscriptions.
if (error.Code != StatusCodes.BadNoSubscription || m_subscriptions.Any(s => s.Created))
{
PublishErrorEventHandler? callback = m_PublishError;

Expand Down