Change DebugCheck conditional compilation from DEBUG to CHECKED #3496
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When using null telemetry instances for legacy logging or when logging is unnecessary, DEBUG builds trigger
Debug.Fail()assertions inDebugCheck()methods, creating a disruptive debugging experience.Changed conditional compilation symbol from
DEBUGtoCHECKEDin twoDebugCheck()methods:LoggerUtils.Null.DebugCheck()in TelemetryUtils.csTelemetryExtensions.DebugCheck()in TelemetryExtensions.csImpact: DebugCheck assertions no longer compiled into DEBUG builds. Methods only included when
CHECKEDsymbol is explicitly defined, allowing intentional null telemetry usage without debug interruptions while preserving the ability to track telemetry plumbing issues when needed.Types of changes
Checklist
Further comments
No additional tests required - existing behavior preserved, only removing debug-time assertions. All 299 existing tests pass.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.