Skip to content

Conversation

@tishmen
Copy link

@tishmen tishmen commented Oct 15, 2025

Scope

  • web_debranding

Depends on

  • None

Summary

  • Backend debranding:
    • General Settings: remove the "About" block by dropping <div id='about'> via a safe view inherit.
    • Browser tab: blank the default title fallback by setting <title t-esc="title or ''"> in web.layout (using position="attributes", no full replace).
  • Avoid dangerous replaces:
    • Use position="attributes" for the title tweak.
    • When replacing the Settings block, set view priority=100.

Pre-commit

  • Ran locally; all hooks passed (prettier, ruff, pylint-odoo, OCA hooks).

Tests

  • Unit tests included:
    • Settings form: assert no About section (//div[@id='about'] absent).
    • Title fallback: assert empty when no title is provided, and exact value when provided.
  • Example run:
    ./odoo/odoo-bin -c odoo.conf -d <db> -i web_debranding --test-enable --stop-after-init

Review notes

  • This module focuses on backend debranding only. Portal debranding is in portal_odoo_debranding (PR [19.0][MIG] portal_debranding: migrate #109). Website debranding lives in OCA/website (website_odoo_debranding), and can be migrated separately to keep dependencies optional.

Milan Topuzov added 3 commits October 15, 2025 09:07
…n- QWeb inherit replaces <title> fallback with empty string\n- Added tests: about section removed, title fallback behavior\n- Dropped dialog debranding asset and file
…=100 to settings view replace\n- Switch QWeb title change to position=attributes\n- Add README.rst to satisfy pylint-odoo
@tishmen
Copy link
Author

tishmen commented Oct 15, 2025

Hey @pedrobaeza! Quick summary of what this adds:

  • Removes the “About” block from Settings (safe inherit, priority=100).
  • Blanks the browser tab title fallback in web.layout (position="attributes").
  • It includes unit tests for both behaviors and passes pre-commit (prettier, ruff, pylint-odoo, OCA hooks).

Looking ahead, since there isn’t a module strictly for backend debranding, I think we can consolidate future backend debranding tweaks under this module to keep scope clear and avoid scattering small changes across the repo. Please review and let me know what do you think.

@pedrobaeza
Copy link
Member

Hello, please call it just web_debranding, for following the same pattern of the rest of the modules + remove redundant word odoo.

@tishmen tishmen changed the title [19.0][ADD] web_odoo_debrand: add [19.0][ADD] web_debranding: add Oct 15, 2025
@tishmen
Copy link
Author

tishmen commented Oct 15, 2025

@pedrobaeza The module has been renamed to web_debranding for consistency with the rest of the suite. Thanks!

@pedrobaeza pedrobaeza added this to the 19.0 milestone Oct 15, 2025
@tishmen tishmen force-pushed the 19.0-mig-web_odoo_debrand branch from 05ba48f to c89f2f1 Compare November 9, 2025 19:38
@NICO-SOLUTIONS
Copy link
Member

@tishmen
alright great. thx for pointing to it.
Just to make sure. in #109 you do not render the o_brand_promotion meassage at all. in website_odoo_debranding we had some issues with enterprise planning installation (NICO-SOLUTIONS@24ae015)
I think checking this could make sense.
And i think we should check if we do not multi-debrand stuff across modules.

Cheers Nils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants