[19.0][MIG] mail_activity_unlink_log: migrate to 19.0 #129
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the mail_activity_unlink_log module from Odoo's previous version to 19.0, and moves it from the OCA/social repository to the OCA/mail repository as requested.
Key changes:
- Updated module version to 19.0.1.0.0 in the manifest
- Migrated all module files including models, tests, data, and documentation
- Maintained backward compatibility with existing functionality
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Updated version to 19.0.1.0.0, but website URL still references old repository |
models/mail_activity.py |
Core functionality for logging unlinked activities - code appears compatible with Odoo 19.0 |
tests/test_activity_unlink.py |
Test coverage for activity unlinking behavior |
data/unlink_message.xml |
XML data for message subtype and template definition |
README.rst |
Documentation with multiple references to old OCA/social repository |
static/description/index.html |
Generated HTML documentation with old repository references |
i18n/*.po |
Translation files (Spanish and Italian) |
| Other files | Supporting files like pyproject.toml, __init__.py files, and contributors list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "version": "19.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "CreuBlanca,Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/social", |
There was a problem hiding this comment.
The website URL still references the old repository 'OCA/social', but according to the PR description, this module is being moved to 'OCA/mail'. Update the website field to 'https://github.com/OCA/mail'.
| "website": "https://github.com/OCA/social", | |
| "website": "https://github.com/OCA/mail", |
mail_activity_unlink_log/README.rst
Outdated
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsocial-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/social/tree/19.0/mail_activity_unlink_log | ||
| :alt: OCA/social | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/social-19-0/social-19-0-mail_activity_unlink_log | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/social&target_branch=19.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This addon enforces the creation of a message when an activity is | ||
| unlinked. This change tries to avoid a possible bad practice of deletion | ||
| of an activity without notifying the deletion. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/social/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/social/issues/new?body=module:%20mail_activity_unlink_log%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * CreuBlanca | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Enric Tobella | ||
| - Sumit Basak (`@TheSumitBasak <https://github.com/TheSumitBasak>`__) | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/social <https://github.com/OCA/social/tree/19.0/mail_activity_unlink_log>`_ project on GitHub. |
There was a problem hiding this comment.
Multiple references to 'OCA/social' repository need to be updated to 'OCA/mail' since this module is being migrated to the mail repository. This includes GitHub URLs, badge links, issue tracker links, and project references.
| <p>OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use.</p> | ||
| <p>This module is part of the <a class="reference external" href="https://github.com/OCA/social/tree/19.0/mail_activity_unlink_log">OCA/social</a> project on GitHub.</p> |
There was a problem hiding this comment.
Multiple references to 'OCA/social' repository need to be updated to 'OCA/mail' since this module is being migrated to the mail repository. This includes GitHub URLs, badge links, Weblate translation project URLs (should reference 'mail-19-0'), issue tracker links, and Runboat links.
| <p>This module is part of the <a class="reference external" href="https://github.com/OCA/social/tree/19.0/mail_activity_unlink_log">OCA/social</a> project on GitHub.</p> | |
| <p>This module is part of the <a class="reference external" href="https://github.com/OCA/mail/tree/19.0/mail_activity_unlink_log">OCA/mail</a> project on GitHub.</p> |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 18.0\n" |
There was a problem hiding this comment.
The Project-Id-Version references "Odoo Server 18.0" but this module is being migrated to version 19.0. This should be updated to "Odoo Server 19.0" to match the target version.
| "Project-Id-Version: Odoo Server 18.0\n" | |
| "Project-Id-Version: Odoo Server 19.0\n" |
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 14.0\n" |
There was a problem hiding this comment.
The Project-Id-Version still references "Odoo Server 14.0" but this module is being migrated to version 19.0. This should be updated to "Odoo Server 19.0" to match the target version.
| "Project-Id-Version: Odoo Server 14.0\n" | |
| "Project-Id-Version: Odoo Server 19.0\n" |
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 14.0\n" |
There was a problem hiding this comment.
The Project-Id-Version still references "Odoo Server 14.0" but this module is being migrated to version 19.0. This should be updated to "Odoo Server 19.0" to match the target version.
| "Project-Id-Version: Odoo Server 14.0\n" | |
| "Project-Id-Version: Odoo Server 19.0\n" |
|
Thanks for the move, but you should keep the commit history. That can be done following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0, but adding the 2 remotes (social and mail), and touching slightly the command for using the social remote instead of |
2 participants
Migration of
mail_activity_unlink_logmodule to Odoo 19.0.Moved from
OCA/socialtoOCA/mailas requested.