[18.0][MIG] attachment_preview: Migration to 18.0 #552
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
ByteMeAsap
force-pushed
the
18.0-mig-attachment_preview
branch
15 times, most recently
from
5a9e1bc to
4675660
Compare
github-actions
bot
removed
the
stale
|
@ByteMeAsap thank you for your contribution! Please squash the last two commits. Also please squash all the administrative commits with the |
[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint
[REM] Old files [ADD] Magic to travis file [FIX] Nagivation refresh widget
Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/sl/
Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/tr/
…_attachment_preview
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/
Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/es/
Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/
Increased code coverage Changed layout of attachment_preview buttons Updates
ByteMeAsap
force-pushed
the
18.0-mig-attachment_preview
branch
from
8470908 to
52934ee
Compare
|
tendil
left a comment
tendil
left a comment
There was a problem hiding this comment.
@ByteMeAsap thank you for your contribution!
Please check my comments
| @@ -0,0 +1,3 @@ | |||
| ## Addon icon | |||
|
|
|||
| - courtesy of <http://commons.wikimedia.org/wiki/Crystal_Clear> | |||
There was a problem hiding this comment.
Remove references in CREDITS.md of past financed migrations by other companies.
wiki/Migration-to-version-18.0
| ], | ||
| "web.assets_frontend": [], | ||
| "web.assets_tests": [], | ||
| "web.qunit_suite_tests": [], |
| self.env[model].with_context(bin_size=True).browse(ids_to_browse) | ||
| ): | ||
| result[this.id] = False | ||
| # result[this.id] = False |
| if model == self._name and binary_field == "datas" and this.store_fname: | ||
| if ( | ||
| model == self._name and binary_field == "datas" and this.store_fname | ||
| ): # pragma: no cover |
There was a problem hiding this comment.
we deliberately do not test this execution path? (# pragma: no cover)
| _inherit = "ir.attachment" | ||
|
|
||
| @api.model | ||
| def get_binary_extension(self, model, ids, binary_field, filename_field=None): |
There was a problem hiding this comment.
all methods must have a clear dockstring in the standard format, please add
There was a problem hiding this comment.
@tendil this is a migration PR, so the code stays as is
Aldeigja
left a comment
Aldeigja
left a comment
There was a problem hiding this comment.
@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files.
Tested on version 14, it works there.
20 participants
No description provided.