Skip to content

Conversation

@bosd
Copy link
Contributor

@bosd bosd commented Dec 29, 2025

Standard migration using odoo-module-migrator .

This version is severly cleaned according to:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Total reduction from 202 to 105 commits (44% reduction)

Also lists the depends properly.

@bosd bosd force-pushed the 19.0-mig-product_contract branch 2 times, most recently from 663c231 to be0367d Compare December 30, 2025 09:12
@bosd
Copy link
Contributor Author

bosd commented Dec 30, 2025

/ocabot migration product_contract

@OCA-git-bot
Copy link
Contributor

Sorry @bosd you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@bosd bosd force-pushed the 19.0-mig-product_contract branch 4 times, most recently from 53f361e to 3600f5d Compare December 30, 2025 13:52
@bosd bosd marked this pull request as ready for review December 30, 2025 13:53
@pedrobaeza
Copy link
Member

/ocabot migration product_contract

@bosd I see that you have generated Merged bot/translation changes commits, while the idea is to squash that ones into the real commit that generates them (i. e. [IMP], [FIX] or [MIG] commits).

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Dec 30, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 30, 2025
25 tasks
@bosd
Copy link
Contributor Author

bosd commented Dec 30, 2025

/ocabot migration product_contract

@bosd I see that you have generated Merged bot/translation changes commits, while the idea is to squash that ones into the real commit that generates them (i. e. [IMP], [FIX] or [MIG] commits).

Yeah, I noticed that the custom script i used, created this..
(On this module it was a but to much to do manually).
It's not optimal oca style, but decided to open this pr anyway, and see how this "lands".

@pedrobaeza
Copy link
Member

Uhm, I don't think it's OK, as now it's even more confusing about its source. I would prefer to let them as it was than this way.

Ted Salmon and others added 16 commits December 30, 2025 19:59
* Add contract functionality to `product.templates`
* Add logic to create contracts from `sale.order` that contains contract products.
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
- On Sale Order confirmation, a contract is created for each contract template used on sale order lines
- A not finished contract can be mentioned on sale order line
- A sale order line linked to a contract will update it and don't create a new one if it had the same template
recurring_next_date should be computed by contract line to get default value
- Sale order line for contract product pass to nothing to invoice on order confirmation
- Contract Invoices are linked to sale order line
mourad-ehm and others added 25 commits December 30, 2025 19:59
…ree not editable

Before this changes, when trying to edit a line of sale order, it was
opening the form of the line. But following the way to work of odoo
with sale event, we have make a new contract configurator that will
be opened when selecting a product of type contract.
…using confirmation date_start

With these changes, we allow the contract line start date to be computed
using the order confirmation date. When the product is configured with
any of the options set in contract_start_date_method other than manual,
the start date will be calculated based on the established date and the
selected period.

Additionally, we can force the month in which we will work in case the
frequency is yearly, quarterly, or semesterly.

Is not added support for daily, weekly or monthlylastday in this commit.
…ttings

[IMP] product_contract: add Recurrence Number to compute start and end dates

[FIX] product_contract: add sol name dependes

[IMP] product_contract: add recurrence interval

[IMP] product_contract: add recurring_interval
…d to recurrence_number

for more clarity rename default_qty to recurrence_number
…ack a contract template

Before this commit, confirming a sales order would raise an exception if any line lacked a configured contract template, preventing the creation of the contract.

Now, sales order lines without a contract template are automatically added to a new contract without a template, allowing the process to continue seamlessly.
@bosd bosd force-pushed the 19.0-mig-product_contract branch from 3600f5d to 53cde28 Compare December 30, 2025 19:04
@bosd
Copy link
Contributor Author

bosd commented Dec 30, 2025

It is ok now

@bosd bosd force-pushed the 19.0-mig-product_contract branch from 53cde28 to 321af49 Compare January 2, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.