Remove @embroider/addon-shim from ember-repl #2067
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove addon-shim from ember-repl
This task successfully removes the
@embroider/addon-shimdependency from the ember-repl package, as it's no longer needed for modern Ember v2 addons.Completed:
config/addon-main.cjsfile that uses addon-shimpackage.jsonto remove@embroider/addon-shimdependencypackage.jsonto remove themainfield fromember-addonconfigpackage.jsonto removeaddon-main.cjsandconfigfrom files arraypackage.jsonto remove the export foraddon-main.jsChanges Made:
@embroider/addon-shimfrom dependencies in package.jsonconfig/addon-main.cjsfile that was using the addon-shimmainfield from theember-addonconfigurationaddon-main.cjsandconfigfrom the files array./addon-main.jsexport from package.jsonPackage builds successfully. This follows the same pattern used by the
repl-sdkpackage in this monorepo.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.