Skip to content

Fix double registration of default multitouch device #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullPointerDepressiveDisorder merged 2 commits into from
Dec 4, 2025
Merged

Fix double registration of default multitouch device #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5257f
Initial plan
Copilot Dec 4, 2025
cce3a91
fix(device): Prevent double registration of default multitouch device
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions MiddleDrag/Managers/DeviceMonitor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class DeviceMonitor {
Log.info("DeviceMonitor starting...", category: .device)

var deviceCount = 0
var registeredDevices: Set<UnsafeMutableRawPointer> = []

// Try to get all devices
if let deviceList = MTDeviceCreateList() {
Expand All @@ -82,6 +83,7 @@ class DeviceMonitor {
let deviceRef = UnsafeMutableRawPointer(mutating: dev)
MTRegisterContactFrameCallback(deviceRef, deviceContactCallback)
MTDeviceStart(deviceRef, 0)
registeredDevices.insert(deviceRef)
deviceCount += 1

if device == nil {
Expand All @@ -93,14 +95,19 @@ class DeviceMonitor {
Log.warning("MTDeviceCreateList returned nil, trying default device", category: .device)
}

// Also try the default device
// Also try the default device if not already registered
if let defaultDevice = MultitouchFramework.shared.getDefaultDevice() {
MTRegisterContactFrameCallback(defaultDevice, deviceContactCallback)
MTDeviceStart(defaultDevice, 0)
deviceCount += 1

if device == nil {
device = defaultDevice
if !registeredDevices.contains(defaultDevice) {
MTRegisterContactFrameCallback(defaultDevice, deviceContactCallback)
MTDeviceStart(defaultDevice, 0)
registeredDevices.insert(defaultDevice)
deviceCount += 1

if device == nil {
device = defaultDevice
}
} else {
Log.debug("Default device already registered from device list", category: .device)
}
}

Expand Down