-
Notifications
You must be signed in to change notification settings - Fork 2
feat: format export timestamps as MM:SS instead of seconds #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change transcript export format from seconds (e.g., "65.50s") to minutes:seconds format (e.g., "1:05") for improved readability. Suggested-by: miguelsilv6 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary of ChangesHello @NotYuSheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience by standardizing the display of transcript timestamps in exported files. Instead of showing raw seconds, all timestamps will now be presented in a clear and intuitive 'minutes:seconds' format, making it much easier for users to quickly grasp the duration of transcript segments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new utility function format_timestamp to convert timestamps from seconds into a more readable MM:SS format. This new function is then consistently applied across markdown and PDF generation for transcript exports, improving the readability of timestamps. The changes are well-implemented and achieve the intended goal. I've added a couple of suggestions to the new format_timestamp function to improve its robustness and readability.
- Handle negative values by ensuring non-negative with max() - Use divmod() for cleaner minutes/seconds calculation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Change transcript export format from seconds (e.g., "65.50s") to minutes:seconds format (e.g., "1:05") for improved readability.
Suggested-by: @miguelsilv6