refactor(wiki): move keydown events to wiki component #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors keyboard event handling by moving keydown event listeners from the documentation-ui module to the wiki component. The refactor improves separation of concerns by consolidating keyboard handling within the component that manages the UI state.
- Moved keydown event handling from documentation-ui to wiki component
- Split keyboard handling into two focused methods: hotkeys and arrow navigation
- Added JSDoc type annotations for better type safety
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| workspaces/documentation-ui/index.js | Removed keydown event listener and added type annotations |
| public/components/wiki/wiki.js | Added consolidated keydown handling with hotkeys and arrow navigation methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
PierreDemailly
approved these changes
Aug 12, 2025
fraxken
changed the title
clemgbld
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.