Skip to content

Rename Test.Settings to Test.TestSettings #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waj merged 1 commit into from
Nov 20, 2025
Merged

Rename Test.Settings to Test.TestSettings #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions nri-prelude/src/Test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ module Test
-- * Running test
run,
runWithSettings,
Settings (..),
defaultSettings,
TestSettings (..),
defaultTestSettings,
)
where

Expand All @@ -43,15 +43,15 @@ import qualified Test.Reporter.Logfile
import qualified Test.Reporter.Stdout
import qualified Prelude

data Settings = Settings
data TestSettings = TestSettings
{ output :: Maybe System.IO.Handle,
junitPath :: Maybe Prelude.String,
writeDevLog :: Bool
}

defaultSettings :: Settings
defaultSettings =
Settings
defaultTestSettings :: TestSettings
defaultTestSettings =
TestSettings
{ output = Just System.IO.stdout,
junitPath = Nothing,
writeDevLog = True
Expand All @@ -69,10 +69,10 @@ defaultSettings =
run :: (Stack.HasCallStack) => Internal.Test -> Prelude.IO ()
run suite = do
args <- System.Environment.getArgs
let settings = defaultSettings {junitPath = getJunitPath args}
let settings = defaultTestSettings {junitPath = getJunitPath args}
runWithSettings settings suite

runWithSettings :: (Stack.HasCallStack) => Settings -> Internal.Test -> Prelude.IO ()
runWithSettings :: (Stack.HasCallStack) => TestSettings -> Internal.Test -> Prelude.IO ()
runWithSettings settings suite = do
-- Work around `hGetContents: invalid argument (invalid byte sequence)` bug on
-- Nix: https://github.com/dhall-lang/dhall-haskell/issues/865
Expand Down