Fix dev reporter memory usage #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging at high throughput, we created loads of new green threads to check whether to advertise `log-explorer`. Changing `concurrently_` to `race_` helped reduce growth rate, but didn't fix things. Splitting off a dedicated advertisement thread made memory usage constant.
brian-carroll
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #141, I noticed our
stdout-prettyreporter uses ridiculous amounts of ram when logging at high thoughput.The reason is for every iteration of
logLoop, we launch a brand new green thread to advertiselog-explorer.Replacing
concurrently_withrace_helped, but memory usage still wasn't constant.Changing to use a dedicated advertisement green thread fixed it.
notice the x axis: we hit 1GB within seconds