Skip to content

luaPlugins.lua-resty-lrucache: init at 0.13; luaPlugins.lua-resty-core: init at 0.1.24 #206813

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
SuperSandro2000:luaPlugins-nginx-lua-module
Dec 30, 2022
Merged

luaPlugins.lua-resty-lrucache: init at 0.13; luaPlugins.lua-resty-core: init at 0.1.24 #206813
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
SuperSandro2000:luaPlugins-nginx-lua-module

Conversation

@SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Dec 19, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 19, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are available on luarocks: https://luarocks.org/search?q=lua-resty-core+ https://luarocks.org/modules/avlubimov/lua-resty-lrucache , can we generate them instead please ? makes maintainance easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are unofficial outdated uploads. For lua-resty-lrucache the version on rocks is 0.09 and 0.13 in the repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use rockspecs from the repo too. The issue is that the repo doesn't contain any rockspec. One can pass an alternative rockspec but it would be easier for everyone if openresty/lua-resty-lrucache#42 could be merged. Maybe nudge the maintainers and ask for an update on luarocks.org while at it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but do we really need one? I have tested the package locally already and it worked.

@SuperSandro2000 SuperSandro2000 force-pushed the luaPlugins-nginx-lua-module branch from aa82476 to e33fb74 Compare December 26, 2022 02:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 26, 2022
@SuperSandro2000 SuperSandro2000 merged commit 0fafbb5 into NixOS:master Dec 30, 2022
@SuperSandro2000 SuperSandro2000 deleted the luaPlugins-nginx-lua-module branch December 30, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants