feat: include leader public key when adding funds#105
Open
mfontanini wants to merge 2 commits intomainfrom
Open
feat: include leader public key when adding funds#105mfontanini wants to merge 2 commits intomainfrom
mfontanini wants to merge 2 commits intomainfrom
Conversation
mfontanini
requested review from
pablojhl and
tim-hm
and removed request for
tim-hm
pablojhl
approved these changes
Mar 14, 2025
tim-hm
reviewed
Mar 19, 2025
client-vms/src/vm/builder.ts
Outdated
Comment on lines
199
to
202
| if ( | ||
| !leaderClusterInfo.publicKeys || | ||
| !leaderClusterInfo.publicKeys.authentication | ||
| ) |
Collaborator
There was a problem hiding this comment.
Nit, but i think this simplifies to: if (!leaderClusterInfo.publicKeys?.authentication) {}
Member
Author
There was a problem hiding this comment.
Yeah I was just copying that pattern
tim-hm
reviewed
Mar 19, 2025
client-vms/src/vm/builder.ts
Outdated
| .id(user_id) | ||
| .signer(signer) | ||
| .leader(leader.transport) | ||
| .leaderPublicKey(leaderClusterInfo.publicKeys?.authentication) |
Collaborator
There was a problem hiding this comment.
nit: is this not type narrowed? eg I think it should be fine as .leaderPublicKey(leaderClusterInfo.publicKeys.authentication)
tim-hm
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the new leader public key logic for add-funds introduced in NillionNetwork/nilvm#67