Skip to content

Refactor onboarding response to use updated profile and payroll structures#8

Merged
jeyongsong merged 3 commits intomainfrom
change-onborading-response
Feb 7, 2026
Merged

Refactor onboarding response to use updated profile and payroll structures#8
jeyongsong merged 3 commits intomainfrom
change-onborading-response

Conversation

@jeyongsong
Copy link
Member

This pull request refactors authentication annotation usage, simplifies the profile model, and enhances onboarding status responses. The most significant changes include renaming the authentication annotation, removing the WorkplaceDto abstraction in favor of a simple string for workplace, and updating onboarding-related DTOs and services to provide richer information. Additionally, validation is improved for incoming requests.

Authentication Annotation Refactor:

  • Renamed the AuthenticatedMember annotation to Auth throughout the codebase, updating all usages and configuration references. (src/main/kotlin/com/moa/common/auth/Auth.kt, src/main/kotlin/com/moa/common/auth/AuthenticatedMemberResolver.kt, src/main/kotlin/com/moa/common/config/SwaggerConfig.kt, src/main/kotlin/com/moa/controller/OnboardingController.kt) [1] [2] [3] [4] [5] [6] [7]

Profile Model Simplification:

  • Removed the WorkplaceDto class and changed the workplace field in Profile, ProfileResponse, and ProfileUpsertRequest from a DTO to a simple string. All related code and service logic were updated accordingly. (src/main/kotlin/com/moa/entity/Profile.kt, src/main/kotlin/com/moa/service/ProfileService.kt, src/main/kotlin/com/moa/service/dto/ProfileResponse.kt, src/main/kotlin/com/moa/service/dto/ProfileUpsertRequest.kt, src/main/kotlin/com/moa/service/dto/WorkplaceDto.kt) [1] [2] [3] [4] [5] [6]

Onboarding Status Response Enhancement:

  • Changed OnboardingStatusResponse to return detailed profile, payroll, and work policy objects (or null) instead of just completion booleans. Updated the service logic to construct these objects with relevant details. (src/main/kotlin/com/moa/service/OnboardingStatusService.kt, src/main/kotlin/com/moa/service/dto/OnboardingStatusResponse.kt) [1] [2] [3] [4]

Validation Improvements:

  • Added validation annotations to KaKaoSignInUpRequest and ProfileUpsertRequest to ensure required fields are not blank, and updated controller methods to enforce validation. (src/main/kotlin/com/moa/service/dto/KaKaoSignInUpRequest.kt, src/main/kotlin/com/moa/service/dto/ProfileUpsertRequest.kt, src/main/kotlin/com/moa/controller/AuthController.kt) [1] [2] [3] [4]

Terms Service Logic Cleanup:

  • Simplified the logic for retrieving and returning term agreements by removing the lazy creation of missing agreements and relying only on existing agreements. (src/main/kotlin/com/moa/service/TermsService.kt)

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results

8 tests   8 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit aee751a.

Copy link
Collaborator

@subsub97 subsub97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD!!!

@jeyongsong jeyongsong merged commit 78589fb into main Feb 7, 2026
2 checks passed
@jeyongsong jeyongsong deleted the change-onborading-response branch February 7, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants