Refactor onboarding response to use updated profile and payroll structures#8
Merged
jeyongsong merged 3 commits intomainfrom Feb 7, 2026
Merged
Refactor onboarding response to use updated profile and payroll structures#8jeyongsong merged 3 commits intomainfrom
jeyongsong merged 3 commits intomainfrom
Conversation
Test Results8 tests 8 ✅ 0s ⏱️ Results for commit aee751a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors authentication annotation usage, simplifies the profile model, and enhances onboarding status responses. The most significant changes include renaming the authentication annotation, removing the
WorkplaceDtoabstraction in favor of a simple string for workplace, and updating onboarding-related DTOs and services to provide richer information. Additionally, validation is improved for incoming requests.Authentication Annotation Refactor:
AuthenticatedMemberannotation toAuththroughout the codebase, updating all usages and configuration references. (src/main/kotlin/com/moa/common/auth/Auth.kt,src/main/kotlin/com/moa/common/auth/AuthenticatedMemberResolver.kt,src/main/kotlin/com/moa/common/config/SwaggerConfig.kt,src/main/kotlin/com/moa/controller/OnboardingController.kt) [1] [2] [3] [4] [5] [6] [7]Profile Model Simplification:
WorkplaceDtoclass and changed theworkplacefield inProfile,ProfileResponse, andProfileUpsertRequestfrom a DTO to a simple string. All related code and service logic were updated accordingly. (src/main/kotlin/com/moa/entity/Profile.kt,src/main/kotlin/com/moa/service/ProfileService.kt,src/main/kotlin/com/moa/service/dto/ProfileResponse.kt,src/main/kotlin/com/moa/service/dto/ProfileUpsertRequest.kt,src/main/kotlin/com/moa/service/dto/WorkplaceDto.kt) [1] [2] [3] [4] [5] [6]Onboarding Status Response Enhancement:
OnboardingStatusResponseto return detailed profile, payroll, and work policy objects (or null) instead of just completion booleans. Updated the service logic to construct these objects with relevant details. (src/main/kotlin/com/moa/service/OnboardingStatusService.kt,src/main/kotlin/com/moa/service/dto/OnboardingStatusResponse.kt) [1] [2] [3] [4]Validation Improvements:
KaKaoSignInUpRequestandProfileUpsertRequestto ensure required fields are not blank, and updated controller methods to enforce validation. (src/main/kotlin/com/moa/service/dto/KaKaoSignInUpRequest.kt,src/main/kotlin/com/moa/service/dto/ProfileUpsertRequest.kt,src/main/kotlin/com/moa/controller/AuthController.kt) [1] [2] [3] [4]Terms Service Logic Cleanup:
src/main/kotlin/com/moa/service/TermsService.kt)