Implement Apple OAuth login using OIDC ID token#11
Merged
Conversation
Test Results8 tests 8 ✅ 0s ⏱️ Results for commit 9283bc1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Apple OAuth support for sign-in and sign-up, alongside various related changes to the authentication flow and configuration. The main updates include new DTOs, controller and service methods, and configuration adjustments to handle Apple as an OIDC provider.
Apple OAuth integration:
AppleSignInUpRequestandAppleSignInUpResponseDTOs for handling Apple sign-in/up requests and responses. (src/main/kotlin/com/moa/service/dto/AppleSignInUpRequest.kt,src/main/kotlin/com/moa/service/dto/AppleSignInUpResponse.kt) [1] [2]appleSignInUpendpoint inAuthControllerand corresponding service logic inAuthServiceto process Apple login using OIDC. (src/main/kotlin/com/moa/controller/AuthController.kt,src/main/kotlin/com/moa/service/AuthService.kt) [1] [2]OIDC provider enhancements:
OidcProviderConfigto include Apple properties and adjustedOidcIdTokenValidatorto support Apple as a provider, including JWKS URI and cache TTL handling. (src/main/kotlin/com/moa/common/oidc/OidcProviderConfig.kt,src/main/kotlin/com/moa/common/oidc/OidcIdTokenValidator.kt) [1] [2]Configuration updates:
application-local.yml,application-prod.yml, andapplication-test.ymlfor proper environment support. [1] [2] [3]Other changes:
INVALID_PROVIDERerror code fromErrorCode.ktas Apple is now a valid provider. (src/main/kotlin/com/moa/common/exception/ErrorCode.kt)moa-secretsubmodule reference. (src/main/resources/moa-secret)These changes collectively enable Apple OAuth flows within the authentication system, ensuring proper validation and token handling for Apple users.