Remove break time fields from work policy model and related classes#10
Merged
Remove break time fields from work policy model and related classes#10
Conversation
Test Results8 tests 8 ✅ 0s ⏱️ Results for commit a1627e0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the break time fields (
breakStartTimeandbreakEndTime) from the work policy data model and related service logic. The changes simplify the handling of work policies by eliminating all references to break times from entities, DTOs, service methods, and validation logic.Data model and DTO changes:
breakStartTimeandbreakEndTimefields from theWorkPolicyVersionentity, as well as from theWorkPolicyUpsertRequestandWorkPolicyResponsedata classes. [1] [2] [3]Service logic updates:
breakStartTimeandbreakEndTimein theWorkPolicyServiceandOnboardingStatusService, including their handling in constructors, updates, and response mapping. [1] [2] [3]validateRequestmethod inWorkPolicyService.